Re: [pgAdmin4] Changes required to support PyCrypto

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4] Changes required to support PyCrypto
Date: 2018-04-10 15:51:36
Message-ID: CA+OCxozKDNm3W3g8sCfK5K6Twy4pGhYm3etoM9juWEKXLnu6aQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

*grumble*. Thanks, applied.

On Tue, Apr 10, 2018 at 1:52 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> On Tue, Apr 10, 2018 at 5:27 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Tue, Apr 10, 2018 at 12:49 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find patch to revert back the changes we have made for
>>> pycryptodom module, This will fix encrypt & decrypt functionality in
>>> python3.
>>>
>>
>> Wait, what? Are you telling me that encrypt/decrypt is broken under
>> Python 3 in the builds I've just pushed?
>>
> ​Only if user's password contains non-ascii characters and running on
> Python3.​
>
>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Joao De Almeida Pereira 2018-04-10 16:00:05 Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree
Previous Message Dave Page 2018-04-10 15:51:24 pgAdmin 4 commit: Fix non-ASCII password decryption/encryption under Py