Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed
Date: 2018-02-09 14:47:17
Message-ID: CA+OCxozK4FeKyugzWNc2aRC1cMONiQMbFgus7Aj=7U28CaKV=Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:

> Hello,
> Attached you can find the fix for the current pronlem
>
>
> On Fri, Feb 9, 2018 at 7:29 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi Joao,
>>
>> It looks like Jenkins has taken umbrage to this change, at least with
>> Python 3.x. Can you take a look please?
>>
>> https://jenkins.pgadmin.org/
>>
>> Thanks.
>>
>> On Fri, Feb 9, 2018 at 11:54 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Thanks, patches applied.
>>>
>>> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira <
>>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>>
>>>> Hi Hackers,
>>>> This is quite a big patch in order to solve the problem with the
>>>> Explain Plan.
>>>>
>>>> We sent 2 patches that have the following:
>>>> *- update-javascript-packages.diff *
>>>> Add package:
>>>> is-docker to select a specific setting when running the Chrome
>>>> tests in
>>>> Docker
>>>>
>>>> Upgrade the version of:
>>>> - babel-loader
>>>> - extract-text-webpack-plugin
>>>> - jasmine-core
>>>> - jasmine-enzyme
>>>> - moment
>>>> *- explain-plan-greenplum.diff*
>>>> Extract SQLEditor.execute and SQLEditor._poll into their own files
>>>> and add test around them
>>>> Extract SQLEditor backend functions that start executing query to
>>>> their own files and add tests around it
>>>> Move the Explain SQL from the front-end and now pass the Explain plan
>>>> parameters as a JSON object in the start query call.
>>>> Extract the compile_template_name into a function that can be used by
>>>> the different places that try to select the version of the template and the
>>>> server type
>>>>
>>>>
>>>> Thanks
>>>> Joao
>>>>
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2018-02-09 14:59:16 Jenkins build is back to normal : pgadmin4-master-python35 #479
Previous Message Dave Page 2018-02-09 14:39:44 pgAdmin 4 commit: Fix tests for Python 3.x