From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | Yosry Muhammad <yosrym93(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [GSoC][Patch] Automatic Mode Detection V1 |
Date: | 2019-06-25 11:09:22 |
Message-ID: | CA+OCxozJqTisLGsv8FvpgNAQu3rVQ8SgtPwdL5XVHYp1AweiYA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Mon, Jun 24, 2019 at 7:03 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
> - What else is missing from this patch to make it applicable ? I would
>> like to produce a release-ready patch if possible. If so, I can continue
>> working on the project on following patches, I just want to know what is
>> the minimum amount of work needed to make this patch release-ready
>> (especially that changes are being made in the master branch that require
>> me to re-edit parts of the code that I have written before to keep things
>> in-sync).
>>
> @Dave Page is the right person to answer this.
>
It needs:
- A code complete feature (or infrastructure/refactoring ready for a
feature), that is acceptable to us. Seems like this is 90% there for an
initial commit.
- Documentation updates.
- Tests for the new feature to ensure it works without needing manual
testing.
- To pass all existing tests (which may be modified if appropriate).
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2019-06-25 11:10:57 | Re: [GSoC][Patch] Automatic Mode Detection V1 |
Previous Message | Aditya Toshniwal | 2019-06-25 11:08:48 | Re: [GSoC][Patch] Automatic Mode Detection V1 |