Re: User management functionality patch [pgadmin4]

Yeah, I was about to reply on this too;

- Why do we need Marshmallow?

- Why do we need a role system? Perhaps in the future we might have shared
servers, and roles that cannot modify them, but not now.

- Why is the editing not done in-grid? It's only a single line per record.
Seems like an awful lot of code for what should be a simple backgrid
implementation.

On Tue, May 31, 2016 at 8:42 AM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Hi Harshal,
>
> Please find the updated patch with some improvement, we should not show
> any of the functions to the non-administrator user.
>
> * Please handle unauthorised routes call using our own wrapper function.
> Because - role_required wrapper redirect the call to unauthorised page,
> which we don't required. We needed proper ajax response.
> * Add search filter on top of grid.
> * Open the form of user, when we add new user.
> * Do not allow to add new user, if the form is not complete for the new
> user.
> * Do not allow to close the form of new user with incomplete data. (Though
> - allow it to remove it.)
> * Close the form on save button call.
> * Allow to change attributes of existing users from the grid itself.
>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Tue, May 31, 2016 at 12:12 PM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB <http://www.enterprisedb.com>
>>
>> On Mon, May 30, 2016 at 4:09 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Harshal,
>>>
>>> PFA comments as below,
>>>
>>> 1) While running setup.py for the first time, We did not handle the case
>>> to create Standard user.
>>>
>> Fixed
>>
>>
>>> 2) Save button gets enable only clicking on input text box
>>>
>> Fixed
>>
>>
>>> 3) Remove delete button from sub-node
>>>
>> Removed button.
>>
>> 4) If current user changes its own name/email, main page should reflect
>>> new changes.
>>>
>> Moved to TODO
>>
>>
>>>
>>>
>>> Can be listed as TODO
>>> --------------------------------
>>> 1) Erros description is missing, for example when have user
>>> test(at)test(dot)com presnt and user try to add user same as test(at)test(dot)com we
>>> get error as "Error during saving user" it should be descriptive like
>>> "ERRPR: User {XYZ} is already exists.."
>>>
>> Fixed. (Added client side validation)
>>
>>
>>> 2) There should be an option to delete multiple users at one shot.
>>>
>> Moved to TODO
>>
>>
>>> 3) There should be an option to active/deactivate multiple users in one
>>> shot.
>>>
>> Moved to TODO
>>
>>
>>> 4) In-place editing in backgrid.
>>>
>> Moved to TODO
>>
>>
>>>
>>>
>>> Regards,
>>> Murtuza
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Fri, May 27, 2016 at 7:02 PM, Harshal Dhumal <
>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA initial patch for User management functionality.
>>>>
>>>>
>>>> --
>>>> *Harshal Dhumal*
>>>> *Software Engineer *
>>>>
>>>>
>>>>
>>>> EenterpriseDB <http://www.enterprisedb.com>
>>>>
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>
>>>>
>>>
>>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company