From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | "Huang, Jun" <huangj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
Cc: | "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Is there a mistake in line 22 of Make.bat? |
Date: | 2021-01-14 09:14:43 |
Message-ID: | CA+OCxozHHs4rDiD05GWLOjzd00h=9z3VZpX7M0eH==ap=b84YQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Thu, Jan 14, 2021 at 1:20 AM Huang, Jun <huangj(dot)fnst(at)cn(dot)fujitsu(dot)com>
wrote:
> Hi,
>
> The following code is line 22 of Make.bat:
> if "%Platform%" == "X86" (
>
> I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the
> result is "x86"(not "X86").
> If it's a mistake, the attached patch adds the changes.
>
Hmm, on the 32bit build VM I get this:
C:\Program Files (x86)\Microsoft Visual C++ Build Tools>echo %Platform%
X86
C:\Program Files (x86)\Microsoft Visual C++ Build Tools>
Which explains why everything works in the production builds. Note that
that system is VS 2015 though, but the 64 bit builds are VS 2017 iirc.
Given that 32 bit Windows builds will be dropped soon, I'm inclined to
leave this as-is for now.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-01-14 09:18:32 | pgAdmin 4 commit: Revert "1) Added support for Kerberos authentication, |
Previous Message | Dave Page | 2021-01-14 09:08:10 | Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires. |