| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Shruti Iyer <siyer(at)pivotal(dot)io> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
| Subject: | Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling |
| Date: | 2017-07-20 12:15:17 |
| Message-ID: | CA+OCxozGimecEvO2xGqpQ6243D-v7kheMFKaxRpJ+mvwt+P5Pw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer <siyer(at)pivotal(dot)io> wrote:
> Hi again!
>
> Attached are the most updated patches. We found an issue with the previous
> implementation. So we generated the new patches.
>
The 01 patch fails linting:
/Users/dpage/git/pgadmin4/web/regression/javascript/history/query_history_spec.jsx
188:9 error Expected indentation of 10 spaces but found 8 indent
196:7 error Expected indentation of 8 spaces but found 6 indent
198:7 error Expected indentation of 8 spaces but found 6 indent
202:12 error Expected indentation of 10 spaces but found 11 indent
205:11 error Expected indentation of 8 spaces but found 10 indent
212:9 error Expected indentation of 10 spaces but found 8 indent
214:11 error Expected indentation of 8 spaces but found 10 indent
217:11 error Expected indentation of 12 spaces but found 10 indent
219:9 error Expected indentation of 6 spaces but found 8 indent
Can you please fix that up and double-check the tests pass?
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | pgAdmin 4 Jenkins | 2017-07-20 12:15:52 | Jenkins build is back to normal : pgadmin4-master-python26 #370 |
| Previous Message | Dave Page | 2017-07-20 12:10:09 | Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid |