Re: Bug #3083 fix

Hi

On Wed, Apr 11, 2018 at 4:46 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:

> Hi Dave,
> Do you still have issues in your environment?
>

I just tested on my MBP, and got the following failure:

======================================================================
ERROR: runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)
Query tool feature test
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_feature_test.py",
line 43, in setUp
self.before()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
line 46, in before
self._reset_options()
File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
line 113, in _reset_options
self.page.fill_codemirror_area_with('')
File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 227, in fill_codemirror_area_with
until(find_codemirror, "Timed out waiting for codemirror "
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 80, in click
self._execute(Command.CLICK_ELEMENT)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 628, in _execute
return self._parent.execute(command, params)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 312, in execute
self.error_handler.check_response(response)
File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
line 242, in check_response
raise exception_class(message, screen, stacktrace)
WebDriverException: Message: unknown error: Element <iframe
cd_frame_id_="6af0765089f43a73f733471ef04cb792">...</iframe> is not
clickable at point (813, 155). Other element would receive the click: <div
class="wcLoadingIconContainer">...</div>
(Session info: chrome=65.0.3325.181)
(Driver info: chromedriver=2.37.544337
(8c0344a12e552148c185f7d5117db1f28d6c9e85),platform=Mac OS X 10.12.6 x86_64)

>
> Thanks
> Joao
>
> On Wed, Apr 11, 2018 at 5:56 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Joao, are you looking at this?
>>
>> On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Tue, Apr 3, 2018 at 6:10 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Argh, managed to send before I finished typing...
>>>>
>>>> On Tue, Apr 3, 2018 at 1:38 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira <
>>>>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>> That looks like in the surrounding area of the change. We run our
>>>>>> pipeline and everything was green.
>>>>>> Can you provide more details, which python version are you using? OS?
>>>>>>
>>>>>
>>>>> That was on my travel laptop, which is macOS Sierra with the Apple
>>>>> supplied Python 2.7.
>>>>>
>>>>> Interestingly, I'm on my dev laptop today (same OS and Python) and
>>>>> it's working just fine. The difference is that the travel machine is a 12"
>>>>> Macbook, whilst the dev machine is
>>>>>
>>>>
>>>> a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if
>>>> the small screen size is causing a problem with this test, something we
>>>> have seen before.
>>>>
>>>>
>>>
>>> Yes, screen size does cause problem. Slick grid does not render all
>>> columns if viewport is not wide enough (like it does for rows).
>>> Remaining columns would render when user scrolls right.
>>>
>>> To avoid similar problem in datatype feature test (commit:
>>> 88bcd3b5129db88975421e26c1bf188daf4892f9
>>> <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h=88bcd3b5129db88975421e26c1bf188daf4892f9>)
>>> I have executed
>>> queries in batch to limit number of columns in single query result.
>>>
>>>
>>>
>>>>
>>>>>
>>>>>>
>>>>>> Thanks
>>>>>> Joao
>>>>>>
>>>>>> On Thu, Mar 29, 2018 at 9:03 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
>>>>>>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>>>>>>
>>>>>>>> Hey Akshay and Neethu
>>>>>>>>
>>>>>>>> We refactored the patch to add tests for the resize feature. We
>>>>>>>> were able to write test cases for the drag event by using spies and setting
>>>>>>>> the rect dimensions. In cases like this, we can just test some components
>>>>>>>> in order to have enough confidence in the code. So we isolated the
>>>>>>>> function that implements the behavior of this feature and tested that it
>>>>>>>> was performing as expected.
>>>>>>>>
>>>>>>>> We ran the patch through the pipelines and all of the tests passed.
>>>>>>>>
>>>>>>>
>>>>>>> I'm consistently seeing the feature test failure below with this
>>>>>>> patch applied:
>>>>>>>
>>>>>>> ============================================================
>>>>>>> ==========
>>>>>>> FAIL: runTest (pgadmin.feature_tests.view_data_dml_queries.
>>>>>>> CheckForViewDataTest)
>>>>>>> Validate Insert, Update operations in View/Edit data with given test
>>>>>>> data
>>>>>>> ------------------------------------------------------------
>>>>>>> ----------
>>>>>>> Traceback (most recent call last):
>>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
>>>>>>> line 125, in runTest
>>>>>>> self._verify_row_data(True)
>>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
>>>>>>> line 325, in _verify_row_data
>>>>>>> self.assertEquals(cells[idx], config_data[str(idx)][1])
>>>>>>> AssertionError: u'[null]' != u'1'
>>>>>>> - [null]
>>>>>>> + 1
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company