Re: [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework
Date: 2016-06-08 12:45:15
Message-ID: CA+OCxozDqbNT5Ub-hUJGXjKkqtAaiiwA_xtwCxB8ntYscH50qQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Jun 8, 2016 at 1:41 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> On Wed, Jun 8, 2016 at 6:07 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Tue, Jun 7, 2016 at 9:44 AM, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > Please find the patch with following changes:
>> > 1. Added help button to the bottom left of the wizard framework.
>> > Usage:
>> > Set wizard_help property with url while creating wizard object.
>> >
>> > var wizard = new (pgBrowser.Wizard.extend({
>> > options: {
>> > title: _('Wizard Title'),
>> > wizard_help: "{{ url_for('help.static',
>> > filename='grant_wizard.html')
>> > }}"
>> > }
>> > })
>> >
>> > 2. Previously wizard progress bar was in bottom left of the wizard
>> > framework
>> > in place of help button.
>> > So, It is now moved to top of Wizard page.
>> >
>> > 3. Added class col-xs-* to the wizard div to be more consistent.
>> >
>> > 4. Set proper height for wizard-right-panel_content in css.
>>
>> Is part of the patch missing? The only visible changes I see are that
>> the buttons are now misaligned (see attached) - note that it's only on
>> the first page, and only when first opened. There's no sign of a help
>> button.
>
> Can you please attach screenshot ?

Sorry :-)

BTW, Chrome 50.0 on OS X 10.11.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
Screen Shot 2016-06-08 at 13.34.22.png image/png 111.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-06-08 12:49:30 Re: pgadmin4: Server does not launch
Previous Message Surinder Kumar 2016-06-08 12:41:31 Re: [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework