Re: [pgAdmin4][debugger]: RM #1354 & RM #1323

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][debugger]: RM #1354 & RM #1323
Date: 2016-06-20 09:21:56
Message-ID: CA+OCxozCBwOnVJ1VycqpTccwQ__ej0sJ-xu0AqwoAwS8oXZwZw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Mon, Jun 20, 2016 at 10:06 AM, Neel Patel
<neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Please find attached modified patch file. Do review it and let us know for
> comments.
>
> Thanks,
> Neel Patel
>
> On Mon, Jun 20, 2016 at 2:08 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Sun, Jun 19, 2016 at 5:50 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>> wrote:
>> > Hi Dave,
>> >
>> > make sense. We should ensure that operations happen sequentially.
>> > Please find attached patch file for the fix.
>>
>> Hmm, using synchronous calls is not an option either. They're strongly
>> discouraged, and will throw warnings on some browsers.
>>
>> Can we not just have the first callback initiate the next call and so on?
>
>
> hmm.. Yes we achieved the same. Please find attached modified patch file.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2016-06-20 09:29:36 [pgAdmin4][Patch]: RM #1351
Previous Message Dave Page 2016-06-20 09:21:46 pgAdmin 4 commit: Fix debugger issues which could occur if one or more