Re: [pgAdmin4][PATCH] Fix handling of double precision[] type

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][PATCH] Fix handling of double precision[] type
Date: 2017-06-15 10:54:25
Message-ID: CA+OCxozBFk=yr+y9F1rNNRqDqnqoo7-UdUmNNc3Y4kyz2XwADg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Thu, Jun 15, 2017 at 11:47 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> HI Dave,
>
> Please find the patch for the added feature test for handling of RM#1928
> datatype issue, other misc changes are for PEP-8.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 8, 2017 at 7:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Thanks, applied.
>>
>> Can you update the data types feature test to cover this case please?
>>
>> Thanks.
>>
>> On Thu, Jun 8, 2017 at 6:51 AM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > PFA patch to fix the handling of double precision[] type.
>> > RM#1928
>> >
>> > Steps to re-produce: Below given query fails to render result in Query
>> > tool,
>> > SELECT ARRAY[1, 'nan', 3]::float[];
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-06-15 10:55:15 Re: pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #
Previous Message Dave Page 2017-06-15 10:54:20 pgAdmin 4 commit: Add double precision[] tests to the query tool.