Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi
>
> On Tue, May 9, 2017 at 1:42 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
> wrote:
>
>> This appears to have made Jenkins get all angry and red :-(
>>
>> https://jenkins.pgadmin.org/
>>
>
> We(Neel and I) have tested it and working fine.
>

It clearly doesn't compile on QT4. Please review the Jenkins logs.

>
>>
>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Thanks patch applied.
>>>
>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Akshay, could you review this please?
>>>>
>>>> Thanks.
>>>>
>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel <
>>>> neel(dot)patel(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Please find attached patch file with the fix of RM #2328 - [Runtime]:
>>>>> Unable to launch query tool and debugger in new browser tab.
>>>>>
>>>>> I have used Qt 5.8 with webkit mentioned in below URL.
>>>>>
>>>>> https://github.com/annulen/webkit/releases
>>>>>
>>>>>
>>>>> As there was a bug in QWebKit regarding "unload" event. We have raised
>>>>> and also they have provided patch file to fix this issue. I have applied
>>>>> the patch in linux and compile the webkit and tested the attached patch
>>>>> with compiled webkit which is now working fine.
>>>>>
>>>>> Below is the link for reference regarding unload issue. They have
>>>>> provided test webkit release for Mac in below URL but for other platform we
>>>>> need to apply the patch and compile the webkit until they provide
>>>>> webkit-releases for all platforms.
>>>>>
>>>>> https://github.com/annulen/webkit/issues/519
>>>>>
>>>>> Do review it and let me know in case of any issue.
>>>>>
>>>>> Thanks,
>>>>> Neel Patel
>>>>>
>>>>>
>>>>> --
>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>>>> To make changes to your subscription:
>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>

--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake