Re: PgAgent Patch

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Mehmet Emin KARAKAŞ <emin100(at)gmail(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PgAgent Patch
Date: 2015-03-03 13:01:46
Message-ID: CA+OCxozAqn99dJh-0Fe3FX9Ham_apOqhpz7uuEHXHyOeKRcTMg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Ashesh; can you please get this reviewed and applied if it looks OK?

Thanks.

On Tue, Mar 3, 2015 at 12:00 PM, Mehmet Emin KARAKAŞ <emin100(at)gmail(dot)com> wrote:
> Hi,
> If batch cron is failed, pgagent doesn't receive error messages. We fix it.
> We canalized the stderr to stdout. This patch batch cron receive error
> massages from nix machine. Git Diff Message and job.cpp file is attached.
>
> Thanks.
>
> --
> MEHMET EMİN KARAKAŞ
> Postgresql Global Username: emin100
>
>
>
> diff --git a/job.cpp b/job.cpp
> index 00334ab..694be22 100644
> --- a/job.cpp
> +++ b/job.cpp
> @@ -273,8 +273,11 @@ int Job::Execute()
> // The *nix way.
> FILE *fp_script;
> char buf[4098];
> +
> + wxString wxSt = wxT("");
> + wxSt.Printf( _("%s 2>&1"), filename.c_str());
>
> - fp_script =
> popen(filename.mb_str(wxConvUTF8), "r");
> + fp_script = popen(wxSt.mb_str(wxConvUTF8) ,
> "r");
> if (!fp_script)
> {
> output.Printf(_("Couldn't execute
> script: %s, errno = %d"), filename.c_str(), errno);
>
>
>
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2015-03-03 16:23:37 pgAdmin 4 commit: Allow modules to create browser panels.
Previous Message Dave Page 2015-03-03 13:01:36 Re: assert "!IsAttached()" failed in SetInvokingWindow()