From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Added basic start up logs for RunTime |
Date: | 2018-09-14 13:43:28 |
Message-ID: | CA+OCxozA+Gvjc3Yfr3d=mCQzv85xRDaLkozPVHVFtUymrDj0kA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied with a couple of tweaks:
- Changed the logfile name to ~/.pgAdmin4.startup.log (for greater
consistency with the runtime log).
- Secured the permissions of the logfile as soon as it's created, to avoid
key leaks.
On Thu, Sep 13, 2018 at 2:06 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:
> Hi Hackers,
>
> I have added basic startup logs for pgAdmin4 RunTime. One log file
> "pgAdmin4_startup.log" will be created in the home directory (same as we
> created for python server logs) every time when pgAdmin4 launched.
>
> I have created one singleton class, so that logging is done through
> multiple files without creating/passing the logger object between multiple
> files.
>
> Attached is the patch, please review it.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-09-14 14:32:55 | Re: [pgAdmin4][Patch]: RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly |
Previous Message | Dave Page | 2018-09-14 13:41:56 | pgAdmin 4 commit: Add a startup logger to the runtime to aid with debug |