Re: Install github app to automatically close PRs on github mirror

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Justin Clift <justin(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL WWW <pgsql-www(at)postgresql(dot)org>
Subject: Re: Install github app to automatically close PRs on github mirror
Date: 2019-06-18 14:42:43
Message-ID: CA+OCxoz9ZAJFnGx19ox2dbD_tJiU51c53VJkCMb+KTSDW_K2Xg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Tue, Jun 18, 2019 at 3:00 PM Stephen Frost <sfrost(at)snowman(dot)net> wrote:

> Greetings,
>
> * Justin Clift (justin(at)postgresql(dot)org) wrote:
> > On 2019-06-17 23:27, Magnus Hagander wrote:
> > >Thanks for your Pull Request! :) This repo on GitHub is just a
> > >mirror of our real git repositories though, and can't really handle
> > >PRs. :( Hopefully you can redo the PR, and direct it to the
> > >git.postgresql.org repos? We have a developer guide, if that
> > >helps:
> https://wiki.postgresql.org/wiki/So,_you_want_to_be_a_developer%3F.
> > >If this was a PR for pgAdmin, please visit
> > >https://www.pgadmin.org/docs/pgadmin4/dev/submitting_patches.html.
> >
> > Hmmm... that wall of text really could do with breaking up if possible.
>
> Agreed.
>
> What about:
>
> --------------
> Thanks for your Pull Request! :) This repo on GitHub is just a
> mirror of our real git repository (which lives on git.postgresql.org)
> though, and can't really handle PRs. :(
>
> If you'd like to see this change in PostgreSQL, please check out our
> developer guide, here:
>
> https://wiki.postgresql.org/wiki/So,_you_want_to_be_a_developer%3F
>
> If this was a PR for pgAdmin, please see this guide instead:
>
> https://www.pgadmin.org/docs/pgadmin4/dev/submitting_patches.html
> --------------
>
> Telling people to direct their PR to the git.postgresql.org repos
> doesn't really make sense...
>

The real question is whether we can put \n in the message. YAML supports it
- no idea if the app does.

Wanna send a patch for testing?

https://github.com/postgres/.github/blob/master/.github/lockdown.yml

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Stephen Frost 2019-06-18 16:18:55 Re: Install github app to automatically close PRs on github mirror
Previous Message Magnus Hagander 2019-06-18 14:25:07 Re: Install github app to automatically close PRs on github mirror