Re: Regarding RM #3316 Pgadmin4 No Tray Crash

Hi

On Tue, Jul 10, 2018 at 11:20 AM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> I have implemented the fix for RM #3316 "Pgadmin4 No Tray Crash". I have
> implemented it as follows:
>
> - Check the availability of System Tray for 30 seconds (no changes
> made here).
> - If System Tray not found create one Floating Window with menu.
> (Refer attached screenshot).
> - I have remove close(x) button of the floating window.
> - Fedora have "Quit" menu for the applications, so I have handle the
> close event and shutdown the python server.
>
> I have tested this on Fedora-28 (no system tray) and Ubuntu 18.04 (with
> system tray).
>
> Please review the screenshot and suggest changes (if any). I'll send the
> patch later.
>

What does the window look like without the menu? I'd suggest putting a
Slonik image there, and maybe a note (or a button to display a note) saying
that installing a system tray plugin can be used to hide the window.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company