| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#3319] Fix the cancel query button glitch in query tool |
| Date: | 2018-07-02 14:37:11 |
| Message-ID: | CA+OCxoz5Y4ewrtViKBimJrWCjCThvnpzctFVUfMQSJoMYtKCTA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Mon, Jul 2, 2018 at 5:58 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix the issue where cancel button remains enabled even after
> the query execution completes, I have moved the enable/disable logic for
> that button with rest of the buttons in '*disable_tool_buttons*' method &
> removed tests which are not required as we are already testing '
> *disable_tool_buttons*' method.
>
> *I had to fix it coz it was annoying me :)*
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2018-07-02 14:43:39 | pgAdmin 4 commit: Cleanup and fix handling of Query Tool Cancel button |
| Previous Message | Aditya Toshniwal | 2018-07-02 12:35:59 | [pgAdmin4][RM3371] Ping endpoint still send a pg4a_session cookie |