Re: Materialized View Patch File

Hi

On Tue, Jul 16, 2013 at 2:58 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Below is the bug description and find attached patch for fix.
>
>
> "If create any MATERIALIZED VIEW with double quote in SQL pane of
> pgAdminIII, the syntax is not displayed properly and it's showing create
> view instead of MATERIALIZED View, and user can not drop that and displayed
> use MATERIALIZED VIEW"
>
> Steps:
>
> 1. Install PostgreSQL 9.3 beta 2
> 2. Launch pgAdmin III
> 3. and create this view from SQL editor
> CREATE MATERIALIZED VIEW public."z a" AS
> select * from emp
> WITH DATA;
> 4. created successfully.
> 5. Click on SQL pane

Isn't the correct fix more like:

wxString sql = wxT("SELECT count(*) FROM pg_matviews WHERE matviewname
= ") + this->GetQuotedIdentifier() + wxT(" AND schemaname = ") +
this->GetSchema()->GetQuotedIdentifier();

The point being that GetQuotedIdentifier() should never need to be
passed through qtDbString(), and always knows the proper quoting rules
for that particular object class (not an issue in this case, but it
can be for things like functions, where the parentheses and arguments
should be excluded from the quoting).

--
Dave Page
Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake