From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Cc: | Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, Anthony Emengo <aemengo(at)pivotal(dot)io>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Subject: | Re: Container build hanging |
Date: | 2018-05-30 21:42:55 |
Message-ID: | CA+OCxoz-HatrnpGDMQNe-8kVn_U-2Ed2v=aXTVfaH0yb4HQeYA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
So it turns out the hang was a result of:
=====
Using the '.eslintignore' config file for excluding the temporary,
vendor specific, and templates files, instead of writing our own logic
to do so.
Patch by: Anthony & Joao
Reviewed by: Khushboo
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
a7ee85619dfd4cf42a43919beeb1cd1680f46d53
Author: Anthony Emengo <aemengo(at)pivotal(dot)io>
Modified Files
--------------
web/.eslintignore | 5 +++++
web/package.json | 2 +-
web/pga_eslint.js | 44 --------------------------------------------
3 files changed, 6 insertions(+), 45 deletions(-)
=====
Reverting that one patch fixes the issue. Can one or more of you take a
look please?
Note that running the Docker build is easy - just install Docker and run
"make docker". However, it uses committed code in the build, so any changes
need to be committed to your local tree or they'll be ignored (yes, we need
to fix that).
Thanks!
On Wed, May 30, 2018 at 3:33 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> The container build is hanging for me on 2 different machines at:
>
> 20:19:50 $ cross-env NODE_ENV=production yarn run bundle:dev
> 20:19:51 $ yarn run linter && yarn run webpacker
> 20:19:52 $ yarn eslint --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx .
> 20:19:52 $ /pgadmin4/web/node_modules/.bin/eslint --no-eslintrc -c
> .eslintrc.js --ext .js --ext .jsx .
>
> Both systems (a Jenkins build node and my laptop) hang at that step,
> seemingly indefinitely.
>
> Running the same (e.g. yarn eslint --no-eslintrc -c .eslintrc.js --ext .js
> --ext .jsx .) is fine directly on my laptop.
>
> Anyone got any ideas why that may be? The only thing I can think of is the
> overly cute unicode symbols that yarn is spitting out may be confusing
> docker.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-05-30 21:47:53 | Re: pgadmin, docker and ipv6 |
Previous Message | Joao De Almeida Pereira | 2018-05-30 21:06:32 | Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1 |