Re: [PATCH] extract function from sqleditor

From: Dave Page <dpage(at)pgadmin(dot)org>
To: George Gelashvili <ggelashvili(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] extract function from sqleditor
Date: 2017-06-07 13:17:23
Message-ID: CA+OCxoz+NBroFgB7iFRr_XzNtW+y+tdaZVgMA48OhnJ-j9BU4g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Mon, Jun 5, 2017 at 9:30 PM, George Gelashvili
<ggelashvili(at)pivotal(dot)io> wrote:
> Hello Hackers!
>
> Re.
> https://www.postgresql.org/message-id/CAFS4TJb-7VTQQrnOi0g6MaoxMfEK9LzCds2yG%2BByS-mLHwydQA%40mail.gmail.com
>
> We extracted the function bound to onSelectedRangesChanged from sqleditor!
>
> - we read through the existing implementation and wrapped it in
> `web/regression/javascript/selection/set_staged_rows_spec.js`
> - we made some changes for clarity
>
> Thanks,
> Joao and George
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-06-07 13:22:17 Re: [pgAdmin4][PATCH] Consolidating gray colors in the application
Previous Message Dave Page 2017-06-07 13:17:13 pgAdmin 4 commit: Extract row staging into it's own module with tests.