Re: RM-4232- Change what is shown by default in tab titles: Implementation suggestion.

On Thu, Oct 8, 2020 at 10:34 AM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> On Thu, Oct 8, 2020 at 2:11 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, Oct 8, 2020 at 6:48 AM Nikhil Mohite <
>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Team,
>>>
>>> Regarding feature RM-4232 <https://redmine.postgresql.org/issues/4232>,
>>> Change what is shown by default in tab titles,
>>>
>>> I had a discussion with Akshay based on that I have added new options in
>>> preferences for the query tool/View-Edit and Debugger.
>>> 1. Query tool and View/Edit:
>>> Added 2 options (placeholders) under display settings of Query Tool.
>>> [image: image.png]
>>> default it is set to what we are currently using, If the user updates
>>> the placeholders we will show the tab titles accordingly.
>>>
>>
>> OK.
>>
>>
>>>
>>> 2. Debugger:
>>> Added tab title place holder in display settings of the debugger.
>>> [image: image.png]
>>> default we are showing only "Debugger" as tab title.
>>>
>>> 1. If the user added any string with a placeholder that string will get
>>> a display in the tab title along with a placeholder.
>>> 2. Tooltip for the tabs will be the same as the placeholders that
>>> the user provided in the preferences.
>>>
>>
>> Currently the tooltips are different iirc, as they sometimes have longer
>> strings. Maybe we should allow them to be customised in the same way?
>>
>
> We can provide separate placeholders for tooltips, but currently, we
> are just adding the "Query Tool - " or "View/Edit Data - " prefix in the
> tooltip.
> e.g: ("Query Tool - TestDB/postgres(at)postgres-12") the remaining
> string is similar to the title string.
>

OK, let's leave that as-is then.

Thanks!

>
>
>>
>>>
>>> Questions:
>>> 1. For scripts we are showing the same title as the Query Tool, do we
>>> need a different placeholder for it or we can reuse the Query Tool
>>> placeholder for it?
>>> (If we need to add a separate placeholder for scripts, where will be
>>> the right place to put it in the preferences?)
>>>
>>
>> No, scripts are just an entry point to the query tool.
>>
>>
>>> 2. Do we need to provide a placeholder for Debugger, as we are showing
>>> only "Debugger" in the title.
>>>
>>
>> I think we should - and that does seem like one case where we should
>> change the default to be the function name or similar.
>>
>>
>>>
>>> Any suggestions or anything I have missed in this please let me know.
>>>
>>
>> The Help text on the Preferences should list the placeholders the user
>> can use (I don't think there's any point in stating what the default is). I
>> would also suggest that setting the value to an empty string should cause
>> it to return to the default (so when the preferences are reopened, the
>> default value is shown, and not an empty string).
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
> Regards,
> Nikhil Mohite.
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com