| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Gurjeet Singh <gurjeet(at)singh(dot)im>, "Ryohei Takahashi (Fujitsu)" <r(dot)takahashi_2(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: doc: pgevent.dll location |
| Date: | 2024-11-05 15:27:03 |
| Message-ID: | CA+OCxoywke+6M7yO7-eUD4RwJiuGk-ydCJqh3bkbG3PjoLAhWg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 5 Nov 2024 at 15:10, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Nov 5, 2024 at 1:00 AM Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
> > I'm unable to confirm the veracity of the claim that the pgevent.dll
> > file on Windows is now placed in a different directory, and that this
> > is a result of meson builds. But the patch looks good to me; it
> > applies cleanly to REL_17_STABLE and main branches.
>
> I think we will need to find someone who can confirm whether or not
> the claim is correct.
>
It is correct. In v16, it was in lib/, in v17, bin/.
However, on Windows I think it probably makes (marginally) more sense to
include it in bin/ - we already have other libraries in there that are
linked at compile time. pgevent is something of a special case, but it's
probably more similar to those libraries than the extensions etc. that are
in lib/.
Related sidenote: I got a complaint today that pg_regress.exe is no longer
part of the Windows installation footprint - and indeed, it's not installed
at all with Meson builds, which is problematic for those doing CI/CD
testing of extensions.
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2024-11-05 15:41:24 | Re: SQL Property Graph Queries (SQL/PGQ) |
| Previous Message | Aleksander Alekseev | 2024-11-05 15:22:50 | Re: New function normal_rand_array function to contrib/tablefunc. |