| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#2989] To fix the issue in Table node |
| Date: | 2018-03-07 16:29:25 |
| Message-ID: | CA+OCxoywkaEX7VL-4G_p=DeLAFyWmSAOGGd+JOMNQ-bew1_eMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> PFA updated patch.
>
>
Using your example on the ticket, I added a "character varying (32)" column
with NOT NULL to the table. When I then edit the column, and turn off NOT
NULL (making no other changes), the SQL generated is:
ALTER TABLE public.test_drop
ALTER COLUMN col2 TYPE character varying (32) COLLATE
pg_catalog."default";
ALTER TABLE public.test_drop
ALTER COLUMN col2 DROP NOT NULL;
I didn't see that when turning off NOT NULL for col1.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | pgAdmin 4 Jenkins | 2018-03-07 16:33:35 | Build failed in Jenkins: pgadmin4-master-python35 #512 |
| Previous Message | pgAdmin 4 Jenkins | 2018-03-07 16:28:24 | Build failed in Jenkins: pgadmin4-master-python27 #511 |