Re: Fixed RM #1356

Hi

On Wed, Jun 15, 2016 at 11:27 AM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:

> Hi
>
> I have fixed RM #1356 "Query tool enhancement". I have added the logic to
> preferences which checks the min/max value before setting it. If value
> given by user is less than min value then set it to min value and if value
> is greater then max value then set it to max value.
>
> For "items_per_page" minimum value is 1. Attached is the patch file.
> Please review it.
>

That doesn't do what I asked for though. A value of zero should be
acceptable (I did say <= 0, but = 0 is probably better), and mean 'disable
paging' (i.e. display unlimited rows, and completely hide the paging
controls). From the ticket:

1) If "Items per page in grid" <= 0, then never page results. Add a note to
that effect on the Preferences pane, and make zero the default value.

The patch does appear to implement:

2) Always allow the user to add a new row in Edit Grid mode. If and only if
there are multiple pages, warn the user ("The result set display will move
to the last page. Do you wish to continue?"), then move to the last page
and add the new row. If there is only one page, just add the new row.

However, if the new row requires a new page to be added (i.e. rows per page
is 10, and you press the + button to add the 11th, 21st...51st row), the
user needs to manually advance a page. I guess the auto advance needs to
happen after the row is added?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company