Re: [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Sarah McAlear <smcalear(at)pivotal(dot)io>
Cc: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, Shruti B Iyer <siyer(at)pivotal(dot)io>, Robert Eckhardt <reckhardt(at)pivotal(dot)io>, Matthew Kleiman <mkleiman(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Joao Pedro De Almeida Pereira <jpereira(at)pivotal(dot)io>, George Gelashvili <ggelashvili(at)pivotal(dot)io>
Subject: Re: [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience
Date: 2017-06-09 08:03:55
Message-ID: CA+OCxoyw5JzCatNiPduaehn2tJrUFc8Oh8=QQ9DDoth9mg_8VA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Jun 8, 2017 at 7:31 PM, Sarah McAlear <smcalear(at)pivotal(dot)io> wrote:
>> Thanks. When I run the tests my browser opens in some default size
>> that's always consistent, but doesn't match my normal Chrome sessions,
>> or the 1024x1024 default set in app_starter.py.
>
>
> This looks like an issue with string edit box placement in the
> implementation. We created an issue for this (RM2477).

That was my guess too.

>> Anyway - I found another issue. If I select one or more columns or
>> rows, or an arbitrary selection of cells, copy/paste seems to work
>> fine. However, if I click the Select All arrow, for a small resultset
>> (e.g. SELECT * FROM pg_database with 18 rows) it works fine, but if I
>> do the same with the contents of pg_class, which has 1342 rows on this
>> DB, it seems to fail to populate the clipboard and ends up pasting
>> whatever was copied previously instead. If I use the Copy button, even
>> on a fast machine it seems to pause for a second or so before failing
>> to put the data on the clipboard.
>
>
> We were able to reproduce this with "SELECT generate_series(1, 50000)"
> The issue was still present for us when we ran the app at each of 2fddf750
> and 495a3cedb
> Could we move this discussion to a new thread as it doesn't seem related to
> these changes?

Something in these changes caused it to start manifesting, but I agree
the underlying issue was probably there anyway. I'm happy to move to a
different thread.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-09 08:09:44 pgAdmin 4 commit: Use the correct font for the treeview.
Previous Message Surinder Kumar 2017-06-09 07:39:43 Re: Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool