Re: Dark mode styling for the website

Hi

On Mon, 10 Oct 2022 at 21:44, Jonathan S. Katz <jkatz(at)postgresql(dot)org> wrote:

> On 10/10/22 12:07 PM, Dave Page wrote:
> > Inspired by Dago A Carralero's email earlier today, I started looking
> > into what it would take to actually add a dark mode to the entire
> > website. Turns out it's not actually that difficult; the attached patch
> > took just a couple of hours of fiddling.
>
> Thanks!
>
> > It leaves the existing styling as the default, and uses CSS media
> > queries to override certain styles if the browser reports that dark mode
> > is preferred. Colours are loosely based on the dark theme for pgAdmin
> > (which is of course, based on PostgreSQL blue), with a few other new
> > ones added where there were no suitable ones in the pgAdmin palette.
> >
> > Of course, this is a PoC at this point, for review and comments. I may
> > have missed some styles, and the actual colors used are obviously a
> > matter for some serious bikeshedding.
> >
> > Thoughts, comments, and paint colour suggestions welcome.
>
> I don't know if I'll have time to test this week due to the major release.

No rush.

>
> My general comment on the patch as is stands is around the heavy use of
> "!important"; if we have to override styles with that, then something is
> not cascading correctly and we should fix that.
>
> Some of the original CSS from the design does have "!important" in it,
> though we've been trying to roll back what we can as we come across it.
> There are some legit use cases (e.g. overriding something Bootstrap is
> doing that we can't otherwise override), but I'd prefer if we don't
> introduce further !important's.

I believe that is what most (all?) of them are doing.

> --
--
Dave Page
https://pgsnake.blogspot.com

EDB Postgres
https://www.enterprisedb.com