| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM3904] Replace charting library Flotr2 with ChartJS using React |
| Date: | 2020-07-23 14:59:40 |
| Message-ID: | CA+OCxoyu2PXDCOWdpMnQL4P=KNFrKk9gN4aAhGiWVnXTqyt=vw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Very nice. One quick issue that I immediately saw - if the dashboard is not
the top-most tab when pgAdmin opens, then when you've selected something on
the treeview and then click on the dashboard tab, the graphs don't populate
until you select a different object.
I'll play some more tomorrow when I have more time.
Thanks!
On Thu, Jul 23, 2020 at 11:58 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to:
> 1) Replace the chart library with Chart.js + ReactJS.
> 2) Add support for ReactJS in pgAdmin with webpack, package.json, linter
> and other changes.
> 3) Add support for testing React components with jasmine test cases. Test
> cases added.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-07-24 06:46:03 | pgAdmin 4 commit: Fixed code smell 'Unused local variables should be re |
| Previous Message | Akshay Joshi | 2020-07-23 13:47:52 | pgAdmin 4 commit: Tag REL-4_24 has been created. |