From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Subject: | Re: PATCH: Login/Group Role Node |
Date: | 2016-02-02 09:55:26 |
Message-ID: | CA+OCxoytmkdf3a-ngUz1r2b_7OU1aC3bCv48T=hofQKM-PYt=A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Tue, Feb 2, 2016 at 9:22 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Ashesh,
>
> I also found that we are not handling group role in macro templates.
>
> Steps to re-produce the issue:
> 1) Create a sample Group Role.
> name : my_group
>
> Click 'Ok' to create.
>
> 2) Go to privilege tab (in my case Database node)
> - Click on Add button
> - Select my_group (Group) from options
> - grant any priviledges
>
> 3) Go to modified SQL tab
>
> - You will see wrong SQL generated
> GRANT ALL ON DATABASE postgres *TO* my_group WITH GRANT OPTIONS
>
> *Expected SQL:*
> GRANT ALL ON DATABASE postgres *TO GROUP* my_group WITH GRANT OPTIONS
>
Isn't GROUP just a noise word that's there for backwards compatibility with
pre-role releases?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Khushboo Vashi | 2016-02-02 10:21:19 | Re: pgAdmin4 PATCH: Domain Module |
Previous Message | Murtuza Zabuawala | 2016-02-02 09:22:39 | Re: PATCH: Login/Group Role Node |