Re: pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

From: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
To: Navnath Gadakh <navnath(dot)gadakh(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Kanchan Mohitey <kanchan(dot)mohitey(at)enterprisedb(dot)com>
Subject: Re: pgAdmin IV : Unittest modular patch (Domains and Tables nodes)
Date: 2016-09-01 11:14:08
Message-ID: CA+OCxoysHrwNcRvFiR9VbGbRRs__h=gW=mzPrTN3j01y4KR5TA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

Please separate the cleanup from the new tests. Each patch should have just
one feature/focus/fix.

Thanks.

On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh <
navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:

> Hello Dave,
> Object cleanup work is completed in above patch. I am working on enhanced
> summary work, once that's complete I will send the revised patch.
>
> Thanks!
>
> On Thu, Sep 1, 2016 at 3:57 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
> wrote:
>
>> Per my earlier email to Priyanka, I'm not going to commit any more test
>> cases until the existing issues are resolved and the enhanced summary and
>> object cleanup work is complete, otherwise it's just taking too much time
>> unnecessarily.
>>
>> Please re-test and resubmit this patch once that work is complete.
>>
>> Thanks.
>>
>> On Tue, Aug 30, 2016 at 1:02 PM, Navnath Gadakh <
>> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>> Please find the patch API unit test cases for Domain & Tables
>>> Nodes.
>>>
>>> This patch also includes code to drop the all objects(like database,
>>> roles, tablespace & server) created during the test suite run.
>>>
>>> *To run the test suite for domain node:*
>>> python regression/runtests.py --pkg browser.server_groups.servers.
>>> databases.schemas.domains
>>>
>>>
>>> *To run the test suite for tables node:*
>>> python regression/runtests.py --pkg browser.server_groups.
>>> servers.databases.schemas.tables
>>>
>>> *To run the test suite for all nodes *(Comment the all test code in
>>> 'synonyms' node i.e. Code under 'tests' directory as its partially
>>> completed):
>>> python regression/runtests.py
>>>
>>>
>>> --
>>> Thanks,
>>> Navnath Gadakh
>>> Software Engineer
>>> EnterpriseDB Corporation
>>> Mobile: +91 9975389878
>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878
>
>
>

--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Navnath Gadakh 2016-09-01 11:21:37 Re: pgAdmin IV : Unittest modular patch (Domains and Tables nodes)
Previous Message Navnath Gadakh 2016-09-01 11:12:36 Re: pgAdmin IV : Unittest modular patch (Domains and Tables nodes)