Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list
Date: 2019-05-20 12:35:17
Message-ID: CA+OCxoyrmhp4C_2OKPaUa3ZgPOXdjbZ4ncGdv+YpYnZUrSjUWw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

OK, well this won't hurt anyway, so patch applied.

Thanks!

On Mon, May 20, 2019 at 11:53 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> Yes, that's is annoying for me too to debug that issue :)
>
> And now setting it "new-password" does not cause the Backgrid to lose
> focus, As of now I can see the only workaround that worked for me in all
> browsers, I've tested in latest Chrome/FF & IE11.
>
>
>
>
> On Mon, May 20, 2019 at 2:32 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Mon, May 20, 2019 at 8:01 AM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to fix the issue with Backgrid PasswordCell.
>>> In the Backgrid PasswordCell, The browser's autocomplete functionality
>>> opens up the saved password list which cause the Backgrid to lose focus
>>> from the current cell and causes issue in keyboard navigation.
>>>
>>
>> This is a much bigger issue - please see the previous discussion at
>> https://www.postgresql.org/message-id/flat/CAFOhELfwsvHDr-jE9V3xZnZugf2LF%2BRbmELxCO2NcrTqYmeS_Q%40mail.gmail.com#931bda161445351150106352b66ced01
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-05-20 12:53:12 pgAdmin 4 commit: Don't try to set permissions on Windows. It won't wor
Previous Message Dave Page 2019-05-20 12:34:50 pgAdmin 4 commit: Prevent Backgrid Password cells from losing focus if