Re: [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window
Date: 2017-06-12 12:46:19
Message-ID: CA+OCxoyrKL7KVOEh0W0bncDfXqzW9JFVCcfMwJY4B5nRZAa8fA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

Can you update this so that the CSS all follows the standards in the
WIP styleguide please? I see that the current patch is using the wrong
font for example.

http://pgadmin4-styleguide.cfapps.io/

Thanks!

On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> Changes:
>
> 1) Calculate text editor position properly when the size of the grid exceeds
> the size of the window.
>
> 2) Assign NumberEditor to cell types('oid', 'xid', 'real').
>
> 3) Remove inline styles from rendered editors and move its styles to CSS
> file.
>
> Please find attached patch and review.
>
> Thanks
> Surinder
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-12 12:50:38 Re: [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button
Previous Message Murtuza Zabuawala 2017-06-12 12:46:18 [pgAdmin4][PATCH] To fix the issue in Role Membership control