From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][RM#3161] Fix PEP-8 issues |
Date: | 2018-03-02 11:59:27 |
Message-ID: | CA+OCxoyppYKJNvZw1Kie4uym8ippNA6yvpEwagkLmhn-d4K75A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied.
On Thu, Mar 1, 2018 at 5:13 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Thank you Joao for reviewing.
>
> On Thu, Mar 1, 2018 at 3:10 AM, Joao De Almeida Pereira <
> jdealmeidapereira(at)pivotal(dot)io> wrote:
>
>> Hello Murtuza,
>>
>> I passed the patch through our CI and all test are green. Also run the
>> codestyle in all those folders and everything is clean.
>>
>> 575 issues to go
>>
>> Thanks
>> Joao
>>
>> On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the PEP8 issues in Casts, Event triggers, Extensions
>>> and Languages module.
>>>
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/languages/
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/extensions/
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/event_triggers/
>>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/
>>> servers/databases/casts/
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-03-02 12:02:00 | pgAdmin 4 commit: Add a makefile target for running PEP8 checks. |
Previous Message | Dave Page | 2018-03-02 11:59:17 | pgAdmin 4 commit: PEP8 fixes for the Casts, Event triggers, Extensions |