Re: PATCH: Debugger Redesign

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Debugger Redesign
Date: 2013-06-25 12:46:34
Message-ID: CA+OCxoypKJoivjv=5DQGwBcXnV1z+bzxDcvJj32a_oKE3HSDmw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Looks good - committed, thanks!

On Tue, Jun 25, 2013 at 9:17 AM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Please find the new patch to take care about the position and size of the
> progress bar in the statusbar.
> It also hides the progress-bar from the statusbar, if number of fileds are
> reduced by the user.
>
>
> On Mon, Jun 24, 2013 at 8:26 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks - I've applied that (I need to cut the beta now, and didn't want
>> to miss this). There are a couple of minor issues - please address them as
>> soon as you can:
>>
>> - As discussed, we should make the progress bar the second field on the
>> bar, not the first.
>>
>> - On Windows, the initial sizing is incorrect. Upon a resize of the
>> window, everything redraws correctly. Please see the attached screenshots.
>>
>> Thanks.
>>
>> On Mon, Jun 24, 2013 at 6:01 AM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Like this?
>>> Please find the updated patch.
>>>
>>>
>>> On Fri, Jun 21, 2013 at 6:39 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>>
>>>> On Thu, Jun 20, 2013 at 8:39 PM, Ashesh Vashi <
>>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Here is one more patch.
>>>>> This patch includes modification related to replacing the progress
>>>>> dialog with a progress bar in the statusbar.
>>>>>
>>>>>
>>>> Yeah, I think that's much better. I think however, that we should
>>>> always show the progress bar on the status bar - otherwise, it looks a
>>>> little weird seeing it flashing on and off, and when it disappears leaving
>>>> the text inset. What do you think?
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>
>
>
> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2013-06-25 13:58:23 Re: PATCH: Debugger Redesign
Previous Message Dave Page 2013-06-25 12:46:14 pgAdmin III commit: Reposition the debugger status bar and ensure it's