Re: [PATCH] Add Commit/Rollback toolbar action

Hi

On Mon, Jun 22, 2015 at 2:02 PM, John Obaterspok <john(dot)obaterspok(at)gmail(dot)com>
wrote:

> Dave,
>
> Regarding "I don't think there is...", was it the width, style or
> something else that you didn't like? The total width with commit/rollback
> icon + the connection drop down is less than 790 px.
> I've changed the arrows so they point to the data store icon (ie commit)
> and from the data store (rollback).
>

It's the overall width of the window. I just measured it on OS X here, and
it's currently ~740px, so two more buttons shouldn't be an issue. I don't
think we want any more though.

>
> I could change it to only show the icons when using auto commit off. Would
> that be better?
>

No, the buttons should always be visible to avoid user confusion.

>
> -- john
>
> 2015-06-19 14:24 GMT+02:00 Dave Page <dpage(at)pgadmin(dot)org>:
>
>> Just that whatever we add needs to match the style of what's there
>> already, and it should convey the purpose of the buttons as clearly as
>> possible. Finally, we only add them if there's physical room when
>> displaying the window on a screen of ~1000px wide. Personally, I don't
>> think there is...
>>
>> On Fri, Jun 19, 2015 at 1:38 AM, Sanket Mehta <
>> sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> Do you have any comments on the same?
>>>
>>> Regards,
>>> Sanket Mehta
>>> Sr Software engineer
>>> Enterprisedb
>>>
>>> On Wed, Jun 17, 2015 at 5:52 PM, John Obaterspok <
>>> john(dot)obaterspok(at)gmail(dot)com> wrote:
>>>
>>>> Thanks,
>>>>
>>>> I can try to look at disabling when not in transaction mode + the short
>>>> cuts.
>>>>
>>>> Regarding the icons, toad for oracle uses a database icon which the
>>>> arrows point to/from. Perhaps we should add something *similar*?
>>>>
>>>> [image: Infogad bild 1]
>>>>
>>>> -- john
>>>>
>>>> 2015-06-17 13:44 GMT+02:00 Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
>>>> :
>>>>
>>>>> Hi John,
>>>>>
>>>>> I have applied the patch and below are my suggestions:
>>>>>
>>>>> 1. Rollback and commit icons should be disabled session is not in
>>>>> transaction mode
>>>>> 2. Rollback and Commit should also be included in Query menu and
>>>>> individual short cut should be assigned to them.
>>>>>
>>>>> Dave,
>>>>>
>>>>> Can we have any other icons for both the functionality as these icons
>>>>> looks odd to me.
>>>>>
>>>>>
>>>>>
>>>>> Regards,
>>>>> Sanket Mehta
>>>>> Sr Software engineer
>>>>> Enterprisedb
>>>>>
>>>>> On Tue, Jun 16, 2015 at 5:03 PM, Sanket Mehta <
>>>>> sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Sure Dave.
>>>>>>
>>>>>> Regards,
>>>>>> Sanket Mehta
>>>>>> Sr Software engineer
>>>>>> Enterprisedb
>>>>>>
>>>>>> On Tue, Jun 16, 2015 at 4:55 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>>
>>>>>>> Sanket, can you look at this please?
>>>>>>>
>>>>>>> Sent from my iPad
>>>>>>>
>>>>>>> > On 15 Jun 2015, at 16:33, John Obaterspok <
>>>>>>> john(dot)obaterspok(at)gmail(dot)com> wrote:
>>>>>>> >
>>>>>>> > Hello,
>>>>>>> >
>>>>>>> > With the newly added option to disable auto commit (hurray) I
>>>>>>> really missed commit/rollback toolbar buttons. Attached patch adds this.
>>>>>>> >
>>>>>>> > -- john
>>>>>>> >
>>>>>>> > <0001-Add-Commit-Rollback-toolbar-action.patch>
>>>>>>> >
>>>>>>> > --
>>>>>>> > Sent via pgadmin-hackers mailing list (
>>>>>>> pgadmin-hackers(at)postgresql(dot)org)
>>>>>>> > To make changes to your subscription:
>>>>>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company