Re: Fixed pgAdmin crash issue

From: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixed pgAdmin crash issue
Date: 2013-09-11 14:31:04
Message-ID: CA+OCxoynPYR-mZuDTT4KuNc6vWG2g_ergMYy3RD8TcVq4XsNAQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - applied to the master and 1.18 branches.

On Tue, Sep 10, 2013 at 1:09 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Please find the patch file in attachment for below described issue in linux.
>
> Steps to reproduce:-
>
> 1. Open pgAdmin and go to database node of larger size.
> 2. Right Click on that database and go to "Backup"
> 3. Give the Filename = "test" and Format = "Custom".
> 4. Click on "Backup" button and immediately click "Cancel" button to cancel
> the
> operation.
> 5. pgAdmin will crash.
>
>
> Findings:-
>
> As we are creating the new process with "wxExecute" to create the Backup and
> user immediately press on "Cancel" then we should first kill the process
> which is created and proper way to delete the process is once we get the
> callback of "EndProcess" not in Abort() method so changed it accordingly.
>
> Kindly let me know for any modification.
>
> Thanks,
> Neel Patel
>
>

--
Dave Page
Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2013-09-12 16:32:10 Re: pgAgent: C++ Port - Patch Review
Previous Message Dave Page 2013-09-11 14:30:51 pgAdmin III commit: Prevent a crash if a user starts an external proces