| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgadmin4][patch] #3099 GPDB: Creating table and creating column in table fails |
| Date: | 2018-02-19 10:40:21 |
| Message-ID: | CA+OCxoymm2OhsSp1940_Ath57M3o3s-oF3CxOiRJnBhGFOrWDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Fri, Feb 9, 2018 at 10:49 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:
> Hi Hackers,
>
> Attached is the patch that correct the creation of tables and columns.
>
> Also started using in a more widespread way the `compile_template_path`
> function to have the logic in a single place.
> Hides the Advanced Tab on table creation for GreenPlum Databases
> Correctly retrieves the collate of the GrenPlum Database in multiples
> places that use it
> Correct the SQL generation for table creation when a primary keys are
> present
>
> Thanks
> Joao
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2018-02-19 10:53:58 | pgAdmin 4 commit: Un-vendorise React, now that it contains bug fixes we |
| Previous Message | Dave Page | 2018-02-19 10:40:14 | pgAdmin 4 commit: Fix creation of tables and columns in GPDB. Fixes #30 |