Re: Patch for pgAdmin Installer web folder upgrade mode.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Paresh More <paresh(dot)more(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Hamid Quddus <hamid(dot)quddus(at)enterprisedb(dot)com>, Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>, Karen Blatchley <karen(dot)blatchley(at)enterprisedb(dot)com>
Subject: Re: Patch for pgAdmin Installer web folder upgrade mode.
Date: 2017-04-10 09:00:04
Message-ID: CA+OCxoyjjEkS90mAQ3Ygqaqz75gohd8WnVn1xZ6Mr6+v9PgFLw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Sun, Apr 9, 2017 at 12:56 PM, Paresh More <paresh(dot)more(at)enterprisedb(dot)com>
wrote:

> Hello Dave,
>
> This is regarding issue # 2187 ( Cleaning up web/* *except* config_local.py)
> through installer. https://redmine.postgresql.org/issues/2187
>
>
> Now Inno installer would clean up web folder except config_local.py in
> upgrade mode and copy latest web folder in the installed location.
>
> Its working fine now.
>
> Attached is the patch for same.
>

I get the following error when building:

Preparing for creation of windows installer...
1 file(s) copied.
Creating windows installer... using INNO tool
Error on line 111 in
C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 9:
Semicolon (';') expected.
Compile aborted.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Paresh More 2017-04-10 09:26:12 Re: Patch for pgAdmin Installer web folder upgrade mode.
Previous Message Dave Page 2017-04-10 08:35:23 pgAdmin 4 commit: Ensure menus are updated after disconnecting a server