Re: pgAdminIV : Regression tests code cleanup

From: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
To: Navnath Gadakh <navnath(dot)gadakh(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Kanchan Mohitey <kanchan(dot)mohitey(at)enterprisedb(dot)com>
Subject: Re: pgAdminIV : Regression tests code cleanup
Date: 2016-10-07 13:01:47
Message-ID: CA+OCxoyfuYnVAx4wgWdeqk_RyJRG5V40fCDejMy-T-bszDjhNA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Awesome - the test suite just found it's first bug! There was a code
path that referenced a variable that hadn't been defined, added in a
patch that I committed earlier without spotting the issue. The
associated tests failed, and I pretty quickly spotted (and fixed) the
bug as a result :-D

Patch applied!

On Fri, Oct 7, 2016 at 1:43 PM, Navnath Gadakh
<navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
> Hi Dave,
> Please find the patch of test framework, which contains
> 1. Code changes (due to drop objects functionality).
> 2. Quoting for database names in drop databases.
> 3. Code changes for import errors for pickle_path and advanced_config
> variables.
>
> Run test suite by this command:
> python runtests.py
>
> Thanks.
> --
> Regards,
> Navnath Gadakh
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>

--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Navnath Gadakh 2016-10-07 13:08:22 Re: pgAdminIV : Regression tests code cleanup
Previous Message Dave Page 2016-10-07 12:59:46 pgAdmin 4 commit: Major update to the test suite: