Re: [pgAdmin4][Patch]: Improvise the treeview element selection

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Shirley Wang <swang(at)pivotal(dot)io>
Cc: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Improvise the treeview element selection
Date: 2017-07-24 07:54:21
Message-ID: CA+OCxoyfpSRM6r35S9DdCW+yESLjro-5S4EDXDXvFz=ZosxVCw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Jul 24, 2017 at 8:51 AM, Shirley Wang <swang(at)pivotal(dot)io> wrote:

> Hi Surinder,
>
> This change seems to be different from the other patterns for selected /
> highlighted options. Is there a reason why this needs to be more visible
> than it already is? In terms of feedback on the tree, we have not heard any
> pains from users that this is not visible enough.
>

Yeah, I'm inclined to agree. What's your motivation for this change? I've
also never heard of any complaints about this.

>
> Shirley
>
> On Mon, Jul 24, 2017 at 12:47 PM Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi All,
>>
>> Changes:
>>
>> 1. Highlight the full selected tree item instead of highlighting only
>> label.
>> 2. Set selected item background color to dark blue that is more visible
>> to eyes.[same as in pgAdmin3]
>>
>> Please find attached patch and review.
>>
>> Thanks,
>> Surinder
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-07-24 09:30:03 Re: [pgAdmin4][Patch]: Improvise the treeview element selection
Previous Message Shirley Wang 2017-07-24 07:51:23 Re: [pgAdmin4][Patch]: Improvise the treeview element selection