Re: [patch] Correct bundle test that polluted Python modules

Hi

On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira
<jdealmeidapereira(at)pivotal(dot)io> wrote:
> Hi Hackers,
>
> Attached you can find the patch that corrects that Bundle tests that was
> polluting the os and subprocess modules.
>
> This patch reverts the commit that skipped the test.

This is almost exactly what Ashesh and I came up with (along with a
few other variations). Unfortunately, whilst all the other tests now
pass, the second execution of the bundler test fails with:

======================================================================
FAIL: runTest (pgadmin.utils.javascript.tests.test_javascript_bundler.JavascriptBundlerTestCase)
scenario name: JavascriptBundlerTestCase
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
line 44, in runTest
self._bundling_succeeds()
File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
line 70, in _bundling_succeeds
self.mockSubprocess.call.assert_called_once_with(['yarn', 'run',
'bundle:dev'])
File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/mock/mock.py",
line 947, in assert_called_once_with
raise AssertionError(msg)
AssertionError: Expected 'call' to be called once. Called 0 times.

----------------------------------------------------------------------

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company