| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved |
| Date: | 2016-12-16 11:52:50 |
| Message-ID: | CA+OCxoye7d0F8dt8UKAQan2b+fzVB=v919=MTkwVZ4R-wx3Hug@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Fri, Dec 16, 2016 at 8:47 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:
> Hi All
>
> Please find the attached patch to fix the RM #1807 Query Tool Does Not
> Recognize When File Changes Have Been Saved.
>
If I open a file with the patch applied, and make a change (add a space to
the end), it's correctly detected.
If I then undo the change by deleting the space, the file is still marked
as dirty.
If I then clear the window entirely, the save button is disabled, but the
tab still shows the file is dirty (the *).
Also - the patch seems to undo the change I made
in 4a280b251755091af9bf56bcdee964601df104ae.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-12-16 11:59:41 | pgAdmin 4 commit: Show index columns in the correct order in RE-SQL. Fi |
| Previous Message | Ashesh Vashi | 2016-12-16 10:16:18 | Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin |