Re: Materialized View Patch File

From: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Materialized View Patch File
Date: 2013-06-03 18:32:37
Message-ID: CA+OCxoydMxnaRYRTMz3SS+py3epWoCUrvM5rb5ck=HOHg9UdDg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Jun 3, 2013 at 7:29 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
>
>
> On Mon, Jun 3, 2013 at 5:20 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
> wrote:
>>
>> Hi
>>
>> On Mon, Jun 3, 2013 at 7:56 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>> wrote:
>> > Hi Dave,
>> >
>> > Thanks for update.
>> >
>> > Yes it is a bug, I have not put the version check.
>> >
>> > Below are the changes.
>> > --- Put the PG version check for mat views
>> > --- In SQL Pane window change the the description of the view from --
>> > MATERIALIZED View: xxx TO
>> > -- Materialized View: xxx
>> >
>> > Please find the updated patch in attachement.
>>
>> Thanks - a few more comments now I've tested further:
>>
>> - The tab should be called "Materialization" (unless someone has a better
>> idea)
>>
> I will fix it.
>
>>
>> - I can still enable the "Materialized View" option on a 9.2 database
>> on the dialogue.
>>
>
> I will fix it.
>
>>
>> - I can't select a tablespace from the drop down menu, but I can type
>> a name in. Should be select-only - see dlgTable.
>
>
> I will fix it.
>
>>
>>
>> - The vacuum options UI design should match the existing one on
>> dlgTable (it's a nice design, but consistency comes first).
>
>
> Can we change dlgTable with new UI design ?

Not for this release, it's too late.

--
Dave Page
Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2013-06-05 07:50:49 Re: Materialized View Patch File
Previous Message Neel Patel 2013-06-03 18:29:02 Re: Materialized View Patch File