Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Thanks, patch applied.

On Thu, Jun 22, 2017 at 11:06 AM, Khushboo Vashi
<khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached fix for the same.
>
> Thanks,
> Khushboo
>
> On Thu, Jun 22, 2017 at 2:18 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hmm, yes - and it's not giving the normal error instructing the user
>> to set the path, but another one: "Failed to load preference
>> pg_bin_dir of module paths".
>>
>> Khushboo, can you investigate and fix ASAP please?
>>
>> On Thu, Jun 22, 2017 at 9:31 AM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi Khusboo,
>> >
>> > Looks like given change have broken Backup, Restore, Import/Export &
>> > Maintenance, even if I have binary path set it is throwing an error.
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Wed, Jun 21, 2017 at 9:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> >>
>> >> Thanks, patch applied!
>> >>
>> >> On Wed, Jun 21, 2017 at 12:44 PM, Khushboo Vashi
>> >> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>> >> > Hi,
>> >> >
>> >> > Please find attached patch to fix RM #2487: get_preference() uses a
>> >> > synchronous AJAX request.
>> >> >
>> >> > Introduced the client side caching for preferences to get rid of
>> >> > synchronous
>> >> > AJAX request.
>> >> >
>> >> >
>> >> > Thanks,
>> >> > Khushboo
>> >>
>> >>
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company