| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch for RM2243 and RM2244 [pgAdmin4] |
| Date: | 2017-03-17 10:34:36 |
| Message-ID: | CA+OCxoyXX20oEJVL3-Rf=Zt0=rrYyftden0LX5K2+8mcL_Tj=g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Fri, Mar 17, 2017 at 7:02 AM, Harshal Dhumal
<harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Here is patch for RM2243 and RM2244
>
> Changes: 1. Pickup correct encoding in qtLiteral to decode.
> 2. While releasing database connection only decode database name if it's not
> unicode.
This fixes 2243, but 2244 is an SQL error that occurs when querying
tables with no columns in the Query Tool. Although Fahar found it
whilst testing with an Arabic name, it's otherwise unrelated.
Patch committed to fix 2243 only.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2017-03-17 10:50:04 | Re: [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences. |
| Previous Message | Dave Page | 2017-03-17 10:33:07 | pgAdmin 4 commit: Fix dropping of databases with Unicode names. Fixes # |