Re: [pgAdmin4]: RM-1910 - Remember last used directory in the file manager

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4]: RM-1910 - Remember last used directory in the file manager
Date: 2016-12-09 12:24:47
Message-ID: CA+OCxoyWoADZV-Usb5tkJqEcV7Gj7_ZRTW9s7AymDJep69oayA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Fri, Dec 9, 2016 at 10:23 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached patch file which contains the fix of last used
> directory in file manager.
> Now file manager will remember last used directory per user basis and will
> be store in SQLite database.
>
> Do review it and let us know for comments.

To avoid an exception, I had to change the hunk at line 578 of
file_manager/__init__.py to check for self.dir == None, e.g.

dir = self.dir if self.dir is not None else ''
if not dir.endswith('/'):
dir += '/';

However, I then ran into a problem that if the directory that has been
remembered no longer exists, I get an error message. I believe it
should traverse back up the path to find the closest directory that is
still present.

Can you look at that please?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-12-09 12:42:34 pgAdmin 4 commit: Only show the filename in query tool tabs, not the wh
Previous Message Dave Page 2016-12-09 12:05:58 Re: [pgAdmin4][Patch]: RM #1994 Insert / update are truncating if column is character