From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4]: Fix for RM #3248 |
Date: | 2018-04-05 10:28:41 |
Message-ID: | CA+OCxoySpg36pCGZVA9yTCv98RG8UV-hb0fj_JLL3DXLO-8Smw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied.
On Thu, Apr 5, 2018 at 7:49 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:
> Hi,
>
> Please find updated patch after fixing the comments.
> Review it and let me know for comments.
>
> Thanks,
> Neel Patel
>
> On Thu, Apr 5, 2018 at 11:32 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
> wrote:
>
>> Thanks Murtuza & Khushboo.
>> I will send updated patch.
>>
>> Thanks,
>> Neel Patel
>>
>> On Thu, Apr 5, 2018 at 11:29 AM, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Neel,
>>>
>>> Add below code to the top (around line no 8) in
>>> alertify.pgadmin.defaults.js file will solve the problem.
>>>
>>> alertify.defaults.closable = false;
>>>
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Thu, Apr 5, 2018 at 11:13 AM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Neel,
>>>>
>>>> Can we make the change in wrapper instead of changing every where?
>>>> File: ../web/pgadmin/static/js/alertify.pgadmin.defaults.js
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> On Thu, Apr 5, 2018 at 11:04 AM, Neel Patel <
>>>> neel(dot)patel(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Please find attached patch for the fix of RM #3248 - we have modified
>>>>> alertify confirm dialog to modal dialog.
>>>>>
>>>>> Do review it and let me know for comments.
>>>>>
>>>>> Thanks,
>>>>> Neel Patel
>>>>>
>>>>
>>>>
>>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Khushboo Vashi | 2018-04-05 10:31:48 | Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree |
Previous Message | Dave Page | 2018-04-05 10:28:21 | pgAdmin 4 commit: Ensure Alertify dialogues are modal to prevent them b |