From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Paresh More <paresh(dot)more(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [Patch]: Installer: pgAdmin4 should not install in special character path |
Date: | 2017-11-20 16:41:00 |
Message-ID: | CA+OCxoyQ_tzKwU0PzPY1Pi1a6CbgKFPWR6_Nj_MKr=Pgb=PntA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied with minor changes to the default paths (to make them match
my machine, which uses all default paths).
On Fri, Nov 17, 2017 at 12:17 PM, Paresh More <paresh(dot)more(at)enterprisedb(dot)com>
wrote:
> Hello Team,
>
> I have made three changes for installer generation scripts.
>
> 1) Modified Make-MinGW.bat to support yarn and nodejs validation in the
> script and also QT 5.9.1 support.
>
> 2) Bug fix for RM1365.
> Currently string datatypes used in Inno tool does not support regular
> expression, so added a user function which will do path validation and it
> would be work fine for inno unicode setup.
>
> 3) Restructured installer script so that it should support unicode inno
> and for RM1365 as well i.e Inno Setup Installer(unicode) also updated
> README file for the same.
>
>
> Please note - Installer path validation is invoked two times
>
> 1) Inno tool internally validate's path which user program do not have
> access to it , so section [MESSAGE] error string message will be used to
> show error message string.
>
> 2) From the code section, so section [CustomMessages] error message will
> be used.
>
> For both (1) and (2) common error message will be used.
>
>
> Attached is the patch
>
>
> --
>
> Thanks & Regards
>
> *Paresh More*
>
> [image: NEW-EDB-logo-4c]
>
> Pune, India.
> www.enterprisedb.com
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-11-20 16:41:24 | Re: Build failed in Jenkins: pgadmin4-master-python26 #510 |
Previous Message | Dave Page | 2017-11-20 16:38:30 | pgAdmin 4 commit: Prevent the Windows installer accepting paths contain |