Re: PATCH: Enable backwards search in SQL Box

From: Dave Page <dpage(at)pgadmin(dot)org>
To: "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Enable backwards search in SQL Box
Date: 2014-02-20 11:22:48
Message-ID: CA+OCxoyQ+rn_BTA=7K-uTaB8XyULPzJKws4XhJdOhxboAH0Weg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Ashesh, can you look at, and if appropriate, commit this please?

Thanks.

On Mon, Feb 17, 2014 at 5:46 PM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:
> Hello!
>
> Pressing F3 in query editor makes the previously started search
> continue forwards.
> This patch adds expected behavior for Shift-F3.
>
> There is a minor inconvenience when just changing the search direction
> - you have to press (Shift-)F3 *twice* for the (previous)next occurence
> to get highlighted. That's because first time goes for cursor movement
> to the corresponding boundary of current occurence. But that also
> happens when search direction is changed with dialog radio-buttons, so
> I think it's ok.
>
> --
> Best regards,
> J.F.
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2014-02-20 11:39:57 Re: PATCH: Enable backwards search in SQL Box
Previous Message J.F. Oster 2014-02-17 17:46:17 PATCH: Enable backwards search in SQL Box