Re: process_executor.py error

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Usman Muzaffar <usman(dot)muzaffar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: process_executor.py error
Date: 2018-10-11 12:13:18
Message-ID: CA+OCxoyMS4RkFYn1G_XUeiynrCfA8xgUnEEt8_h4vFbiXcrhGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Thu, Oct 11, 2018 at 12:51 PM Usman Muzaffar <
usman(dot)muzaffar(at)enterprisedb(dot)com> wrote:

> +++ a little more information for the issue
>
>
> i - The file(log_file) mode was 'ab' due to which it was throwing
> concatenation error.
> ii- I have change the file opening mode to 'a' after which the issue is
> not encountered.
>
> The issue can be reproduced as following
>
> i) Enable Python 3.6 virtual environment
> ii) move to web/regression folder
> iii) trigger following command
> python runtests.py --exclude feature_tests
> iv) The terminal will show the error while any test case throws exception
> and that is caught.
>
>
>
>
>
>
> On Thu, Oct 11, 2018 at 3:46 PM, Usman Muzaffar <
> usman(dot)muzaffar(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> While running API test cases, i encountered following error in
>> process_executor.py file
>>
>> ==============================================
>>
>> fp.write('EXCEPTION::\n{0}'.format(res))
>>
>> TypeError: a bytes-like object is required, not 'str'
>>
>> ==============================================
>>
>>
>>
>> so changed the file opening mode to 'a'. The API test cases are again run
>> without this error with following versions
>> i) Python 2.7
>> ii) Python 3.4
>> iii) Python 3.5
>> iiii) Python 3.6
>>
>> Please review the patch and commit.
>>
>>
>> --
>>
>>
>> Thanks,
>>
>> Usman Muzaffar
>> QA Team
>> EnterpriseDB Corporation
>>
>
>
>
> --
>
>
> Thanks,
>
> Usman Muzaffar
> QA Team
> EnterpriseDB Corporation
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-10-11 12:24:02 pgAdmin 4 commit: Additional Bootstrap 4 fixes:
Previous Message Dave Page 2018-10-11 12:13:12 pgAdmin 4 commit: Log process exceptions using ASCII mode to avoid issu