Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Robert Eckhardt <reckhardt(at)pivotal(dot)io>
Cc: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website
Date: 2017-07-18 12:20:33
Message-ID: CA+OCxoyM4HeQ1Yd-vZMz0UMrc6mCM-bGqcXzDZdzOYAJhu09yg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Jul 18, 2017 at 1:15 PM, Robert Eckhardt <reckhardt(at)pivotal(dot)io>
wrote:

> Looks good.
>

Thanks. I just noticed though, that we're trying to link to github.css, and
failing. Was that intended to be in the same directory as all the scss?

>
> I assumed American spelling, should we use proper English spelling? Our
> prodigious use of the 'z' (pronounced zee) definitely improves our scrabble
> scores.
>

That's a definite benefit. I tend to try to use en_GB by default, partly
because I'm, well, English, and partly because I like to wind up people who
think the only English is en_US (of which there are a surprisingly large
amount).

>
> -- Rob
>
> On Tue, Jul 18, 2017 at 7:54 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Mon, Jul 17, 2017 at 7:51 PM, Joao De Almeida Pereira <
>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>
>>> Hello Hackers,
>>>
>>> With this patch we added the style guide to the current pgAdmin website.
>>> It is not 100% migrated yet, but we already have the Alerts and colors.
>>>
>>>
>> Thanks - applied with some minor styling and layout changes. Please check
>> I didn't break anything.
>>
>> You obviously miss-spelt "colour", but I let that slide :-p
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Shirley Wang 2017-07-18 13:22:16 Re: Testing out font changes in query editor tool
Previous Message Robert Eckhardt 2017-07-18 12:15:40 Re: [pgadmin-hackers][pgaweb][Patch] Add style guide to pga website