Re: v3.0 release on hold

Hi

On Thu, Mar 22, 2018 at 1:00 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

>
>
> On Thu, Mar 22, 2018 at 3:22 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, Mar 22, 2018 at 9:21 AM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave
>>>
>>> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> We've run into a number of unexpected issues with the v3.0 release that
>>>> I think we need to resolve before moving forwards. For the time being, only
>>>> patches critical to fix these issues should be committed.
>>>>
>>>> I'll try to look at 1, though I do have another deadline I need to
>>>> meet.
>>>> Akshay, can you look at 2 please?
>>>> Fahar is already looking at 3.
>>>> Khushboo, can you look at 4 please?
>>>>
>>>> Thanks all.
>>>>
>>>> 1) There is no longer a system tray in Gnome 3.26 and later, and thus
>>>> the runtime won't initialise in Fedora 27 and later. We need an alternative
>>>> for this, either a tray replacement that the RPM can depend on, or better
>>>> yet, support whatever it is Gnome expect such apps to use these days.
>>>>
>>>> 2) Starting a second instance of the app bundle on Mac doesn't always
>>>> open a new pgAdmin window as it should. It works fine in the debugger, or
>>>> if you start the app with a command like: "/Applications/pgAdmin\
>>>> 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click
>>>> the appbundle or use a command like "open /Applications/pgAdmin\ 4.app"
>>>>
>>>
>>> Still working on this, not found any solution yet.
>>>
>>
> Not able to figure out the solution yet. I have tried to debug
> the code, but every time it will create a new instance(tray icon). Do I
> need to look into the code or something related to app bundle may be some
> settings in info.plist or any other pointer?
>

Have a look at the code around line 85 an onwards of pgAdmin4.cpp. It
creates the shared memory interlock (and log/address files) based on the
current username and a hash of the executable name/path. My suspicion is
that the path hash (which is calculated from argv[0] on line 72) is for
some reason getting a different value each time when launched via the
Finder or "open", thus the interlock is failing.

>
>>>> 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my
>>>> copy, but apparently his is a fresh installation.
>>>>
>>>
>>> I have tried on Windows 7 and Windows 8.1 64 bit clean VM (created
>>> using ISO file) and pgAdmin4 is working fine on both. I have given the same
>>> ISO file to Khushboo and she has created VM for both the OS and it is
>>> crashed on her machine (seems strange behaviour), only difference is
>>> version of VMWare fusion. I have 6.0.6 and she has 7.0.1
>>>
>>
>> Is it possible that on one virtual machine VMware Tools were installed,
>> but not on the other? I ask because I believe they install a version of the
>> MSVC runtime.
>>
>
> On both machine VMware tools were installed.
>

Odd. Very odd.

>
>>
>>>
>>>> 4) On my Windows 7 machine, after running a backup I get no status
>>>> window, and see the following in the logs:
>>>>
>>>> Traceback (most recent call last):
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py",
>>>> line 209, in run_wsgi
>>>> execute(self.server.app)
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py",
>>>> line 197, in execute
>>>> application_iter = app(environ, start_response)
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py",
>>>> line 1997, in __call__
>>>> return self.wsgi_app(environ, start_response)
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py",
>>>> line 1985, in wsgi_app
>>>> response = self.handle_exception(e)
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py",
>>>> line 1540, in handle_exception
>>>> reraise(exc_type, exc_value, tb)
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py",
>>>> line 1982, in wsgi_app
>>>> response = self.full_dispatch_request()
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py",
>>>> line 1614, in full_dispatch_request
>>>> rv = self.handle_user_exception(e)
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py",
>>>> line 1517, in handle_user_exception
>>>> reraise(exc_type, exc_value, tb)
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py",
>>>> line 1612, in full_dispatch_request
>>>> rv = self.dispatch_request()
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py",
>>>> line 1598, in dispatch_request
>>>> return self.view_functions[rule.endpoint](**req.view_args)
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py",
>>>> line 792, in decorated_view
>>>> return func(*args, **kwargs)
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py",
>>>> line 62, in index
>>>> return make_response(response=BatchProcess.list())
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py",
>>>> line 584, in list
>>>> details = desc.details(p.command, args)
>>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py",
>>>> line 190, in details
>>>> res += html.safe_str(cmd + self.cmd)
>>>> AttributeError: 'BackupMessage' object has no attribute 'cmd'
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company